fix makefile #336
Merged
fix makefile #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 51.50% 51.42% -0.08%
==========================================
Files 43 43
Lines 5186 5186
==========================================
- Hits 2671 2667 -4
- Misses 2321 2323 +2
- Partials 194 196 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
jpinsonneau
reviewed
May 22, 2023
jpinsonneau
reviewed
May 22, 2023
| OCI_BIN_PATH = $(shell which podman || which docker) | ||
| OCI_BIN ?= $(shell v='$(OCI_BIN_PATH)'; echo "$${v##*/}") | ||
| OCI_BIN_PATH := $(shell which podman || which docker) | ||
| OCI_BIN ?= $(shell basename ${OCI_BIN_PATH}) |
jpinsonneau
previously approved these changes
May 22, 2023
Signed-off-by: Mohamed Mahmoud <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.