Improve script to replace images for OLM #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make those scripts work for OLM as well Need to provide CSV & NAMESPACE info, e.g: `CSV=network-observability-operator.v1.2.0 NAMESPACE=openshift-netobserv-operator VERSION=test USER=jotak make set-plugin-image`
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 51.34% 51.42% +0.07%
==========================================
Files 43 43
Lines 5155 5186 +31
==========================================
+ Hits 2647 2667 +20
- Misses 2310 2323 +13
+ Partials 198 196 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
msherif1234
reviewed
May 9, 2023
| namespace=$2 | ||
| rel_name=$3 | ||
| env_name=$4 | ||
| new_image=$5 |
| echo $idx_env | ||
| patch2="{'op': 'replace', 'path': '/spec/install/spec/deployments/0/spec/template/spec/containers/0/env/$idx_env', 'value': {'name': '$env_name', 'value': '$new_image'}}" | ||
|
|
||
| oc patch csv $csv_name -n $namespace --type='json' -p "[$patch1, $patch2]" |
There was a problem hiding this comment.
can u check the return code here and indicate if the patch was success or not ?
|
Can u pls update |
|
/lgtm |
jotak
added
no-qe
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make those scripts work for OLM as well
Need to provide CSV & NAMESPACE info, e.g:
CSV=network-observability-operator.v1.2.0 NAMESPACE=openshift-netobserv-operator VERSION=test USER=jotak make set-plugin-image