-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-904: Make v1beta1 the storage version #308
NETOBSERV-904: Make v1beta1 the storage version #308
Conversation
Signed-off-by: msherif1234 <[email protected]>
@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: msherif1234 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 49.67% 50.10% +0.43%
==========================================
Files 43 43
Lines 5075 5075
==========================================
+ Hits 2521 2543 +22
+ Misses 2344 2325 -19
+ Partials 210 207 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e204644
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* NETOBSERV-904: Make v1beta1 the stored version Signed-off-by: msherif1234 <[email protected]> * use none default value when update flowcollector object to recreate SM Signed-off-by: msherif1234 <[email protected]> --------- Signed-off-by: msherif1234 <[email protected]>
since we have now a release out with v1beta1, its time to make
v1beta1
as the storage apis versiontested on OCP cluster