Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-928 Connection tracking renaming #303

Merged
merged 1 commit into from
Mar 21, 2023
Merged

NETOBSERV-928 Connection tracking renaming #303

merged 1 commit into from
Mar 21, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 20, 2023 •
edited
Loading

outputRecordTypes -> logTypes
connection -> conversation

spec:
...
  processor:
...
    logTypes: FLOWS
    conversationHeartbeatInterval: 30s
    conversationEndTimeout: 10s

Let's merge this first for consistency (at user level) and see if we do the renaming in FLP component in a followup since there are lots of changes

@jpinsonneau jpinsonneau requested a review from jotak March 20, 2023 11:42
@jpinsonneau jpinsonneau added no-qe This PR doesn't necessitate QE approval breaking-change This pull request has breaking changes. They should be described in PR description. labels Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #303 (03d9b78) into main (44e1b37) will decrease coverage by 0.60%.
The diff coverage is 36.11%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   49.66%   49.06%   -0.60%     
==========================================
  Files          43       43              
  Lines        5020     5020              
==========================================
- Hits         2493     2463      -30     
- Misses       2324     2350      +26     
- Partials      203      207       +4
Flag Coverage Δ
unittests 49.06% <36.11%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go 0.27% <0.00%> (ø)
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go 42.33% <0.00%> (ø)
controllers/consoleplugin/consoleplugin_objects.go 92.45% <0.00%> (ø)
controllers/constants/constants.go 100.00% <ø> (ø)
pkg/helper/flowcollector.go 61.70% <50.00%> (ø)
controllers/flowlogspipeline/flp_common_objects.go 84.85% <100.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jpinsonneau jpinsonneau removed the no-qe This PR doesn't necessitate QE approval label Mar 20, 2023
Amoghrd
Amoghrd reviewed Mar 20, 2023
View reviewed changes
bundle/manifests/flows.netobserv.io_flowcollectors.yaml
default: FLOWS
description: logTypes defines the desired record types to generate.
Possible values are "FLOWS" (default) to export flowLogs, "CONVERSATIONS"
to generate newConnection, heartbeat, endConnection events,
Copy link
Contributor

@Amoghrd Amoghrd Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpinsonneau should it be Conversation here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without doing the FLP renaming, we will have to keep these events

let's secure this first and see how long it will take to merge FLP renaming ?

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 20, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:ba8464c
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ba8464c
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ba8464c

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ba8464c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 20, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 20, 2023
@jotak
Copy link
Member

jotak commented Mar 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e5e7b33 into netobserv:main Mar 21, 2023
@jpinsonneau jpinsonneau mentioned this pull request Mar 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amoghrd Amoghrd Amoghrd left review comments

@jotak jotak Awaiting requested review from jotak

Assignees

@jotak jotak

Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpinsonneau @Amoghrd @jotak @openshift-merge-robot