NETOBSERV-927 Improve servicemonitor/prometheusrule checking changes … #302
Conversation
…perf Only check for spec change, not meta NB: namespace or name changes follow a different process; it is safe to not check for name/namespace changes there; you cannot anyway update a resource for a namespace or name change
|
@OlivierCazade when you have time to review, this should be a small perf improvement on the operator side |
jotak
added
no-qe
|
@OlivierCazade done - also added labels to service monitors |
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 49.81% 49.38% -0.44%
==========================================
Files 43 43
Lines 4984 5036 +52
==========================================
+ Hits 2483 2487 +4
- Misses 2301 2339 +38
- Partials 200 210 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…perf
Only check for spec change, not meta
NB: namespace or name changes follow a different process; it is safe to not check for name/namespace changes there; you cannot anyway update a resource for a namespace or name change