NETOBSERV-90: enable deployment as Daemonset #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mariomac
commented
Nov 25, 2021
mariomac
commented
- Adding a HostPort to the container specification in the DaemonSet
- Setting the proper RBAC permissions
- Enable the deployment in the master node
OlivierCazade
approved these changes
Nov 25, 2021
| @@ -172,7 +173,6 @@ func (r *FlowCollectorReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| Owns(&corev1.ConfigMap{}). | |||
| Owns(&appsv1.Deployment{}). | |||
| Owns(&appsv1.DaemonSet{}). | |||
| Owns(&corev1.Service{}). | |||
There was a problem hiding this comment.
It is duplicated 2 lines below.
|
/lgtm thanks Mario |
jpinsonneau
requested changes
Nov 26, 2021
Comment on lines
79
to
83
| func buildPodTemplate(desired *flowsv1alpha1.FlowCollectorGoflowKube, forDaemonSet bool) corev1.PodTemplateSpec { | ||
| cmd := buildMainCommand(desired) | ||
| return &corev1.PodTemplateSpec{ | ||
| var ports []corev1.ContainerPort | ||
| var tolerations []corev1.Toleration | ||
| if forDaemonSet { |
There was a problem hiding this comment.
can't we use desired.Kind == constants.DaemonSetKind here instead of an additionnal parameter ?
- Adding a HostPort to the container specification in the DaemonSet - Setting the proper RBAC permissions - Enable the deployment in the master node
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.