KIND: Fix output path for api conversation generation + Fix webhook ca bundle injection for flow-collector CRD #284
Conversation
Fix the logic to detect if the cloned repo is in the GOPATH by removing a the hardcoded path `$(GOPATH)/src/network-observability-operator` and instead just check if the $(ROOT_DIR) is in the $(GOPATH) or not with string comparisons. Also update the conversions with the new controller-gen version. Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
force-pushed
the
fix-kind
branch
3 times, most recently
from
14938cd to
00fcdc8
Compare
astoycos
changed the title
|
/assign @msherif1234 This should be good to go now! |
| @@ -21,3 +21,11 @@ spec: | |||
| secret: | |||
| defaultMode: 420 | |||
| secretName: webhook-server-cert | |||
| --- | |||
| # The following patch adds a directive for certmanager to inject CA into the CRD | |||
There was a problem hiding this comment.
isn't better/cleaner to have this in its own patch file and let kustomization patch it ?
There was a problem hiding this comment.
Sure, it's just a preference thing I can do that if you'd like, I wish I could just point to ../crd/patches/cainjection_in_flowcollectors.yaml but it won't let me point to that file from the kubernetes/ directory
There was a problem hiding this comment.
just wanted to keep the original sdk yamls as close as the original auto generated ones so any future interactions with sdk-operator will be smooth
There was a problem hiding this comment.
I can do that later if needed
There was a problem hiding this comment.
All good I can do it now
msherif1234
added
no-qe
|
also there is no longer version updates so pls adjust the title and PR description just indicating for kind we need to have cert-mage CA or something similar |
astoycos
changed the title
Signed-off-by: Andrew Stoycos <[email protected]>
msherif1234
changed the title
astoycos
changed the title
astoycos
changed the title
astoycos
changed the title
|
tested and lgtm, thanks @astoycos ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes two bugs:
There are still some webhook issues when running on KIND... specifically I spin things up with
IMG="quay.io/bpfd/network-observability-operator:test" make image-build image-pushmake local-deployIMG="quay.io/bpfd/network-observability-operator:test" make deploy-kindmake deploy-sample-crI run into
operator Logs:
This PR fixes the aforementioned bug by ensuring we inject the webhook ca-bundle into the flow-collector CRD definition.
The makefile logic to detect weather or not the cloned code is in gopath is flawed....specifically
Assumes that you specifically cloned the code to
$GOPATH/src/network-observability-operatorwhich probably isn’t the case for everyonefor example on my setup the repo lives at
/home/astoycos/go/src/github.com/netobserv/network-observability-operatorso although it’s in my GOPATH we still set --output-base here when we don’t need to. Ultimately I was seeingzz_generated.conversion.goget put in the wrong spot because of thisThe fix just makes sure that the $GOPATH is in wherever the code lives (i.e $ROOT_DIR)