NETOBSERV-382: Added status field in HPA configuration #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierCazade
force-pushed
the
add-hpa-status
branch
from
00db923 to
a49d384
Compare
jotak
reviewed
Oct 27, 2022
api/v1alpha1/flowcollector_types.go
Outdated
| type FlowCollectorHPA struct { | ||
| // +kubebuilder:validation:Enum:=DISABLED;ENABLED | ||
| // +kubebuilder:default:=DISABLED | ||
| // AuthToken describe the way to get a token to authenticate to Loki |
There was a problem hiding this comment.
wrong description, I bet you copy-pasted :D
There was a problem hiding this comment.
Yes sorry, fixed.
jotak
reviewed
Oct 27, 2022
| @@ -94,7 +94,6 @@ spec: | |||
| imagePullPolicy: IfNotPresent | |||
| port: 9001 | |||
| logLevel: info | |||
| autoscaler: null | |||
There was a problem hiding this comment.
could you add a sample autoscaler config, but commented out? I find it quite convenient when trying configs that are not obvious
There was a problem hiding this comment.
thanks! Actually better than commented out :)
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a status field in HPA section to deploy or not HPA.
At some point in the future we may want a third option: not deploying the HPA but also not reconciling pod count so an external HPA can be used.