Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka mk targets #174

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Conversation

memodi
Copy link
Contributor

@memodi memodi commented Sep 28, 2022

@memodi
Copy link
Contributor Author

memodi commented Sep 28, 2022

cc @jotak

@jotak
Copy link
Member

jotak commented Sep 29, 2022

Tested, works fine, thanks @memodi !
/lgtm

@jotak
Copy link
Member

jotak commented Oct 4, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit fe6151e into netobserv:main Oct 4, 2022
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
…e_names

add custom network service names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants