Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing peer map to bpfman volume [BP 1.8] #1070

Merged

Conversation

msherif1234
Copy link
Contributor

Signed-off-by: Mohamed Mahmoud [email protected]
(cherry picked from commit 97f2c6d)

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Signed-off-by: Mohamed Mahmoud <[email protected]>
(cherry picked from commit 97f2c6d)
@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.49%. Comparing base (1cb3584) to head (099546c).
Report is 1 commits behind head on release-1.8.

Files with missing lines Patch % Lines
controllers/ebpf/agent_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #1070      +/-   ##
===============================================
+ Coverage        62.46%   62.49%   +0.02%     
===============================================
  Files               77       77              
  Lines            11581    11581              
===============================================
+ Hits              7234     7237       +3     
+ Misses            3889     3887       -2     
+ Partials           458      457       -1     
Flag Coverage Δ
unittests 62.49% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controllers/ebpf/agent_controller.go 45.96% <0.00%> (ø)

... and 1 file with indirect coverage changes

@openshift-merge-bot openshift-merge-bot bot merged commit 32d9a53 into netobserv:release-1.8 Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants