Skip to content

Commit

Permalink
NETOBSERV-1625: (follow-up) mention other possible cause for ebpf drops
Browse files Browse the repository at this point in the history
  • Loading branch information
@jotak
jotak committed May 10, 2024
1 parent 1162d7a commit 4a83f80
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 21 deletions.
6 changes: 3 additions & 3 deletions apis/flowcollector/v1beta1/flowcollector_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,9 @@ const (
FlowRTT AgentFeature = "FlowRTT"
)

// Name of a ebpf agent alert.
// Name of an eBPF agent alert.
// Possible values are:<br>
// - `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
// `NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
// +kubebuilder:validation:Enum:="NetObservDroppedFlows"
type EBPFAgentAlert string

Expand All @@ -178,7 +178,7 @@ type EBPFMetrics struct {

// `disableAlerts` is a list of alerts that should be disabled.
// Possible values are:<br>
// `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
// `NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
// +optional
DisableAlerts []EBPFAgentAlert `json:"disableAlerts"`
}
Expand Down
6 changes: 3 additions & 3 deletions apis/flowcollector/v1beta2/flowcollector_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ const (
FlowRTT AgentFeature = "FlowRTT"
)

// Name of a ebpf agent alert.
// Name of an eBPF agent alert.
// Possible values are:<br>
// - `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
// `NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
// +kubebuilder:validation:Enum:="NetObservDroppedFlows"
type EBPFAgentAlert string

Expand All @@ -185,7 +185,7 @@ type EBPFMetrics struct {

// `disableAlerts` is a list of alerts that should be disabled.
// Possible values are:<br>
// `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
// `NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
// +optional
DisableAlerts []EBPFAgentAlert `json:"disableAlerts"`
}
Expand Down
12 changes: 6 additions & 6 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,12 @@ spec:
description: |-
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
items:
description: |-
Name of a ebpf agent alert.
Name of an eBPF agent alert.
Possible values are:<br>
- `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
enum:
- NetObservDroppedFlows
type: string
Expand Down Expand Up @@ -3655,12 +3655,12 @@ spec:
description: |-
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
items:
description: |-
Name of a ebpf agent alert.
Name of an eBPF agent alert.
Possible values are:<br>
- `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
enum:
- NetObservDroppedFlows
type: string
Expand Down
12 changes: 6 additions & 6 deletions config/crd/bases/flows.netobserv.io_flowcollectors.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
description: |-
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
items:
description: |-
Name of a ebpf agent alert.
Name of an eBPF agent alert.
Possible values are:<br>
- `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
enum:
- NetObservDroppedFlows
type: string
Expand Down Expand Up @@ -3367,12 +3367,12 @@ spec:
description: |-
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
items:
description: |-
Name of a ebpf agent alert.
Name of an eBPF agent alert.
Possible values are:<br>
- `NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br>
enum:
- NetObservDroppedFlows
type: string
Expand Down
2 changes: 1 addition & 1 deletion controllers/ebpf/agent-metrics.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func (c *AgentController) agentPrometheusRule(target *flowslatest.FlowCollectorE
rules = append(rules, monitoringv1.Rule{
Alert: string(flowslatest.AlertDroppedFlows),
Annotations: map[string]string{
"description": "NetObserv eBPF agent is not able to process new flows as it's hashmap is full. Hashmap table size can be increased by increasing cacheMaxFlows value in Flowcollector resource.",
"description": "NetObserv eBPF agent is not able to process new flows. Possible reasons are the BPF hashmap being full, or the capacity limiter being triggered. Both causes can be worked around by increasing cacheMaxFlows value in Flowcollector resource.",
"summary": "NetObserv eBPF is not able to process any new flows",
},
Expr: intstr.FromString("sum(rate(netobserv_agent_dropped_flows_total[1m])) > 0"),
Expand Down
4 changes: 2 additions & 2 deletions docs/FlowCollector.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ To filter a range of ports, use a "start-end" range, string format. For example
<td>
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br><br/>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br><br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -7620,7 +7620,7 @@ To filter a range of ports, use a "start-end" range, string format. For example
<td>
`disableAlerts` is a list of alerts that should be disabled.
Possible values are:<br>
`NetObservDroppedFlows`, which is triggered when eBPF agent hashmap table is full.<br><br/>
`NetObservDroppedFlows`, which is triggered when the eBPF agent is dropping flows, such as when the BPF hashmap is full.<br><br/>
</td>
<td>false</td>
</tr><tr>
Expand Down

0 comments on commit 4a83f80

Please sign in to comment.