Skip to content

Commit

Permalink
remove RTT unsupported mentions (#509)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpinsonneau authored Dec 11, 2023
1 parent f1e3e9e commit 1821ca0
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions api/v1beta2/flowcollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ type FlowCollectorIPFIX struct {
// Agent feature, can be one of:<br>
// - `PacketDrop`, to track packet drops.<br>
// - `DNSTracking`, to track specific information on DNS traffic.<br>
// - `FlowRTT`, to track TCP latency. [Unsupported (*)].<br>
// - `FlowRTT`, to track TCP latency.<br>
// +kubebuilder:validation:Enum:="PacketDrop";"DNSTracking";"FlowRTT"
type AgentFeature string

Expand Down Expand Up @@ -235,7 +235,7 @@ type FlowCollectorEBPF struct {
// the kernel debug filesystem, so the eBPF pod has to run as privileged.
// If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br>
// - `DNSTracking`: enable the DNS tracking feature.<br>
// - `FlowRTT` [unsupported (*)]: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br>
// - `FlowRTT`: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br>
// +optional
Features []AgentFeature `json:"features,omitempty"`
}
Expand Down
10 changes: 5 additions & 5 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5239,15 +5239,15 @@ spec:
This feature requires mounting the kernel debug filesystem,
so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged`
parameter is not set, an error is reported.<br> - `DNSTracking`:
enable the DNS tracking feature.<br> - `FlowRTT` [unsupported
(*)]: enable flow latency (RTT) calculations in the eBPF
agent during TCP handshakes. This feature better works with
`sampling` set to 1.<br>'
enable the DNS tracking feature.<br> - `FlowRTT`: enable
flow latency (RTT) calculations in the eBPF agent during
TCP handshakes. This feature better works with `sampling`
set to 1.<br>'
items:
description: Agent feature, can be one of:<br> - `PacketDrop`,
to track packet drops.<br> - `DNSTracking`, to track specific
information on DNS traffic.<br> - `FlowRTT`, to track
TCP latency. [Unsupported (*)].<br>
TCP latency.<br>
enum:
- PacketDrop
- DNSTracking
Expand Down
10 changes: 5 additions & 5 deletions config/crd/bases/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5225,15 +5225,15 @@ spec:
This feature requires mounting the kernel debug filesystem,
so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged`
parameter is not set, an error is reported.<br> - `DNSTracking`:
enable the DNS tracking feature.<br> - `FlowRTT` [unsupported
(*)]: enable flow latency (RTT) calculations in the eBPF
agent during TCP handshakes. This feature better works with
`sampling` set to 1.<br>'
enable the DNS tracking feature.<br> - `FlowRTT`: enable
flow latency (RTT) calculations in the eBPF agent during
TCP handshakes. This feature better works with `sampling`
set to 1.<br>'
items:
description: Agent feature, can be one of:<br> - `PacketDrop`,
to track packet drops.<br> - `DNSTracking`, to track specific
information on DNS traffic.<br> - `FlowRTT`, to track
TCP latency. [Unsupported (*)].<br>
TCP latency.<br>
enum:
- PacketDrop
- DNSTracking
Expand Down
2 changes: 1 addition & 1 deletion docs/FlowCollector.md
Original file line number Diff line number Diff line change
Expand Up @@ -9200,7 +9200,7 @@ Agent configuration for flows extraction.
<td><b>features</b></td>
<td>[]enum</td>
<td>
List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br> - `PacketDrop`: enable the packets drop flows logging feature. This feature requires mounting the kernel debug filesystem, so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br> - `DNSTracking`: enable the DNS tracking feature.<br> - `FlowRTT` [unsupported (*)]: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br><br/>
List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br> - `PacketDrop`: enable the packets drop flows logging feature. This feature requires mounting the kernel debug filesystem, so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br> - `DNSTracking`: enable the DNS tracking feature.<br> - `FlowRTT`: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br><br/>
</td>
<td>false</td>
</tr><tr>
Expand Down
4 changes: 2 additions & 2 deletions hack/cloned.flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3626,9 +3626,9 @@ spec:
type: string
type: array
features:
description: 'List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br> - `PacketDrop`: enable the packets drop flows logging feature. This feature requires mounting the kernel debug filesystem, so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br> - `DNSTracking`: enable the DNS tracking feature.<br> - `FlowRTT` [unsupported (*)]: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br>'
description: 'List of additional features to enable. They are all disabled by default. Enabling additional features might have performance impacts. Possible values are:<br> - `PacketDrop`: enable the packets drop flows logging feature. This feature requires mounting the kernel debug filesystem, so the eBPF pod has to run as privileged. If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br> - `DNSTracking`: enable the DNS tracking feature.<br> - `FlowRTT`: enable flow latency (RTT) calculations in the eBPF agent during TCP handshakes. This feature better works with `sampling` set to 1.<br>'
items:
description: Agent feature, can be one of:<br> - `PacketDrop`, to track packet drops.<br> - `DNSTracking`, to track specific information on DNS traffic.<br> - `FlowRTT`, to track TCP latency. [Unsupported (*)].<br>
description: Agent feature, can be one of:<br> - `PacketDrop`, to track packet drops.<br> - `DNSTracking`, to track specific information on DNS traffic.<br> - `FlowRTT`, to track TCP latency.<br>
enum:
- PacketDrop
- DNSTracking
Expand Down

0 comments on commit 1821ca0

Please sign in to comment.