NETOBSERV-179 Topology: create page layout & toolbar #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jpinsonneau
force-pushed
the
topology_view
branch
from
c88c876 to
32273eb
Compare
mariomac
approved these changes
Mar 11, 2022
jpinsonneau
force-pushed
the
topology_view
branch
from
50ada3e to
176e7b5
Compare
|
Added a feature gate so you will not be able to see the |
jpinsonneau
force-pushed
the
topology_view
branch
from
176e7b5 to
d17d359
Compare
mariomac
approved these changes
Mar 17, 2022
jpinsonneau
force-pushed
the
topology_view
branch
from
d17d359 to
61cba18
Compare
|
New changes are detected. LGTM label has been removed. |
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements impact-less solution to switch between table / topology views following that discussion
UI changes between table / topology are managed by switch cases in
netflow-trafficcomponent. That will allow to share selection / filters / data between viewsI took the opportunity to move dropdowns in a folder and did the same with empty topology component for consistency