NETOBSERV-192 Release action #91
Conversation
Similar to the existing push-to-quay action, except it's triggered from tags and will push just 1 image built using that tag as version. https://issues.redhat.com/browse/NETOBSERV-192
|
I'd like to give a try to this "release action" first on the console plugin repo, and if we're happy with it then we can generalize to the other repos |
| name: release to quay.io | ||
| on: | ||
| push: | ||
| tags: [v*] |
There was a problem hiding this comment.
My understanding is that this build is going to be triggered by any branch as long as there is tag, should we try to limit this?
There was a problem hiding this comment.
I don't think we should limit, because tags are not limited to main, for instance v0.1.0 was done on branch release-4.10.
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: ${{ matrix.go }} | ||
| - name: build images |
There was a problem hiding this comment.
May be we could try to use the existing build?
In my opinion building again does not make a difference when creating a new release candidate, but may be better when promoting a release candidate
There was a problem hiding this comment.
there is actually a difference: if we tag then build, the tag version will be passed into the program vars for displaying version, cf https://github.com/netobserv/network-observability-console-plugin/blob/main/Makefile#L80
But, I get the point of promoting an existing image that is already properly tested. There's a tradeoff to do here. Either we rebuild, with the small probability to have something wrong in that build (but builds should be reproducible consistently, so in theory it shouldn't happen) ; or we just promote an existing image, but it won't show the desired version in logs.
There was a problem hiding this comment.
I did not think about version injection.
I agree that rebuilding here is a reasonable risk.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Similar to the existing push-to-quay action, except it's triggered from
tags and will push just 1 image built using that tag as version.
https://issues.redhat.com/browse/NETOBSERV-192