Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cypress column count #701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix cypress column count #701

wants to merge 2 commits into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 28, 2025

No description provided.

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor

@jotak you need to run make update-config first to reconcile operator config with the sample in this repo.
I already have a fix I can push here if you want

@jotak jotak requested a review from jpinsonneau January 28, 2025 14:29
@jotak
Copy link
Member Author

jotak commented Jan 28, 2025

@jotak you need to run make update-config first to reconcile operator config with the sample in this repo. I already have a fix I can push here if you want

I think I did that manually in a previous PR .. but don't hesitate to push here if something is missing

@jpinsonneau
Copy link
Contributor

Here we go ☝️

Copy link

openshift-ci bot commented Jan 28, 2025

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-e2e-console-tests b03f704 link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jotak
Copy link
Member Author

jotak commented Jan 28, 2025

Here we go ☝️

Thanks, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants