-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1450: use isolated states for mobx #450
Conversation
@jotak: This pull request references NETOBSERV-1450 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
- Coverage 58.61% 57.90% -0.72%
==========================================
Files 167 168 +1
Lines 8312 8414 +102
Branches 1061 1061
==========================================
Hits 4872 4872
- Misses 3132 3234 +102
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3f16709 make set-plugin-image |
@jotak - I tried with the PR image, I still see the same exception. Let me know if you need cluster info. |
@memodi did you clear the browser cache? |
yes, it was a fresh load when I tried last and now also tried empty cache and hard reload multiple times, on every refresh I am seeing this error. |
@memodi indeed I also still see the exception in the javascript console, however it seems like the page is now loading fine despite this error: I suspect the remaining error might be something wrong not on netobserv but on the console itself, or on patternfly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, let's just ensure it works on all OCP versions
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jotak - last time when I had tested the error was still thrown, I know you were discussing this with console team - has something changed since then to make error not occur? |
Description
As mobx is also used by the console itself, it must be configured as isolated to prevent conflicting versions.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.