NETOBSERV-1379: show DNS error number #425
Conversation
|
@jpinsonneau: This pull request references NETOBSERV-1379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jpinsonneau: This pull request references NETOBSERV-1379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 58.14% 57.57% -0.58%
==========================================
Files 169 170 +1
Lines 7958 8058 +100
Branches 986 990 +4
==========================================
+ Hits 4627 4639 +12
- Misses 3053 3140 +87
- Partials 278 279 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jpinsonneau
force-pushed
the
1379
branch
2 times, most recently
from
0e87bf3 to
bcc9de7
Compare
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
|
@jpinsonneau: This pull request references NETOBSERV-1379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=b81a3b8 make set-plugin-image |
| @@ -398,6 +399,7 @@ | |||
| "Time elapsed between DNS request and response.": "Time elapsed between DNS request and response.", | |||
| "DNS Response Code": "DNS Response Code", | |||
| "DNS RCODE name from response header.": "DNS RCODE name from response header.", | |||
| "DNS error number returned by bpf_skb_load_bytes function.": "DNS error number returned by bpf_skb_load_bytes function.", | |||
There was a problem hiding this comment.
I would say error code returned from DNS tracker ebpf hook because it doesn't have to be return from bpf_skb_load_bytes plus this too much details to show here IMO
There was a problem hiding this comment.
Sure, sounds better ! 8ffc6cb
| @@ -41,6 +41,7 @@ export const LatencyDonut: React.FC<LatencyDonutProps> = ({ | |||
| name: (m as NamedMetric).fullName || (m as GenericMetric).name, | |||
| value: getStat(m.stats, 'avg') | |||
| })) | |||
| .filter(m => !othersName || m.name !== othersName) | |||
There was a problem hiding this comment.
can u pls explain what this change for ?
There was a problem hiding this comment.
Previously I was querying response codes different from NoError and finding back the NoError count from totals.
|~`"DnsFlagsResponseCode"`!~`"DnsFlagsResponseCode":"NoError"`
This has been changed to all response codes for consistency:
|~`"DnsFlagsResponseCode"`
so the filtering needs to be done on client side when showOthers is not true.
| filtered.push(others); | ||
| } | ||
| filtered = filtered.slice(0, limit); | ||
| const filtered = topKMetrics.filter(m => showOthers || (othersName && m.name !== othersName)).slice(0, limit); |
There was a problem hiding this comment.
this change too pls explain is it relevant to DNSErrno change ?
There was a problem hiding this comment.
same as #425 (comment)
github-actions
bot
removed
the
ok-to-test
|
/lgtm |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=5e1c444 make set-plugin-image |
|
/label qe-approved |
|
@jpinsonneau: This pull request references NETOBSERV-1379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds dns error number field & filter.
It also ensure dns latency metrics query to run only on flows containing
DnsLatencyMsfield.Dependencies
Based on #422
netobserv/netobserv-ebpf-agent#218
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.