Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1313 enable feature gated panels by default #402

Merged
merged 1 commit into from
Oct 4, 2023
Merged

NETOBSERV-1313 enable feature gated panels by default #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web/src/utils/overview-panels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ export const getDefaultOverviewPanels = (): OverviewPanel[] => {
{ id: 'top_dropped_state_donut', isSelected: true },
{ id: 'top_dropped_cause_donut', isSelected: true },
{ id: 'top_dropped_bar_total', isSelected: true },
{ id: 'top_avg_dns_latency_donut', isSelected: false },
{ id: 'top_dns_rcode_donut', isSelected: false },
{ id: 'top_dns_rcode_bar_total', isSelected: false },
{ id: 'top_avg_rtt_donut', isSelected: false },
{ id: 'top_avg_rtt_line', isSelected: false }
{ id: 'top_avg_dns_latency_donut', isSelected: true },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be more selective and not display them all by default? E.g. show donuts, which are more lightweight, than line/bar charts for the same metric ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's more a matter of advertising what's available here more that anything don't you think ?

That selection is kept in cache so this will affect only the first time until the user actually configure the panels (or get new panels not yet assigned from new feature / operator update).

{ id: 'top_dns_rcode_donut', isSelected: true },
{ id: 'top_dns_rcode_bar_total', isSelected: true },
{ id: 'top_avg_rtt_donut', isSelected: true },
{ id: 'top_avg_rtt_line', isSelected: true }
]);
if (isAllowed(Feature.Overview)) {
panels.unshift({ id: 'overview', isSelected: true });
Expand Down