Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makefile #327

Merged
merged 1 commit into from
May 22, 2023
Merged

fix makefile #327

merged 1 commit into from
May 22, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

@msherif1234 msherif1234 requested a review from jpinsonneau May 17, 2023 23:28
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #327 (e918482) into main (d99e5a4) will increase coverage by 0.89%.
The diff coverage is n/a.

❗ Current head e918482 differs from pull request most recent head 17f2d97. Consider uploading reports for the commit 17f2d97 to get more accurate results

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   58.08%   58.97%   +0.89%     
==========================================
  Files         149      120      -29     
  Lines        6615     4880    -1735     
  Branches      792      792              
==========================================
- Hits         3842     2878     -964     
+ Misses       2556     1873     -683     
+ Partials      217      129      -88     
Flag Coverage Δ
uitests 58.97% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

jpinsonneau
jpinsonneau previously approved these changes May 22, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @msherif1234

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

New changes are detected. LGTM label has been removed.

Signed-off-by: Mohamed Mahmoud <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99b3a5f into netobserv:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants