NETOBSERV-908: Added query to get silenced alert and only display non silenced alert #313
Conversation
|
@OlivierCazade: This pull request references NETOBSERV-908 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 58.49% 58.50% +0.01%
==========================================
Files 148 148
Lines 6536 6557 +21
Branches 783 786 +3
==========================================
+ Hits 3823 3836 +13
- Misses 2497 2505 +8
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:7d90df7"]. It will expire after two weeks. |
| ); | ||
| }) | ||
| .catch(() => { | ||
| console.log('Could not get alerts'); |
There was a problem hiding this comment.
nit:
| console.log('Could not get alerts'); | |
| console.log('Could not get silenced alerts'); |
Should we also set silenced alertes to [] to show all alerts in that case ?
There was a problem hiding this comment.
Done, thanks
| getSilencedAlerts() | ||
| .then(result => { | ||
| setSilencedAlerts( | ||
| /* result.filter(rule => rule.status.state == 'active').map(rule => rule.id) */ |
There was a problem hiding this comment.
nit:
| /* result.filter(rule => rule.status.state == 'active').map(rule => rule.id) */ |
|
/label qe-approved |
OlivierCazade
force-pushed
the
silenced-alerts
branch
from
9b90cd8 to
feab6a1
Compare
github-actions
bot
removed
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The banner will only appear after both query have been done and only non silenced alert will appear.