-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nit CSS updates #306
Nit CSS updates #306
Conversation
jpinsonneau
commented
Mar 20, 2023
•
edited
Loading
edited
- border under table headers
- broken lines on right
- increased a bit histogram height
- histogram title (suggestion)
7293f45
to
60d9c42
Compare
<FlexItem flex={{ default: 'flex_1' }}> | ||
<Text>{t('Number of logs over time')}</Text> | ||
</FlexItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a value adding this title on top left corner of the histogram for you guys ?
It would replace a tooltip while hovering the graph
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 58.79% 59.06% +0.26%
==========================================
Files 147 120 -27
Lines 6466 4849 -1617
Branches 772 783 +11
==========================================
- Hits 3802 2864 -938
+ Misses 2449 1856 -593
+ Partials 215 129 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |