-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-787 UI: Table Histogram #271
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd like to tweak the visuals a bit. I'll send something shortly |
Sure @andrew-ronaldson, waiting for your feedback before merging this. Thanks ! |
Let's merge this and do the UI tweaks in a followup. I'd like to unlock #272 /approve |
This implements histogram UI component based on #270 query.
The range is forced while selecting if at least next histogram bar (or more) is less than selected limit:
Increasing the limit allows you to select more at once:
Else the range selection is free and limit will be hit as usual as you can see in the bottom bar:
ToDos:
disable auto range selection when limit is reached at first stepshow start / end as tooltipsKnowns bugs:
can't select range from first click. You need to focus on another element (clic on Traffic flows tab for example) before selecting rangehistogram count mismatch summary countFollowups: