Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-325 Topology: Remove feature gate #143

Merged
merged 1 commit into from
May 2, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 29, 2022

Removed topology feature gate.

I kept the utils/features-gate.ts file as example for next features

@jpinsonneau jpinsonneau requested a review from jotak April 29, 2022 07:20
@jpinsonneau jpinsonneau added the no-qe This PR doesn't necessitate QE approval label Apr 29, 2022
@jotak
Copy link
Member

jotak commented Apr 29, 2022

LGTM but hold until we take a decision (hopefully today)
/lgtm
/hold

@jpinsonneau
Copy link
Contributor Author

Sure @jotak, there is no hurry ⌛

@jotak
Copy link
Member

jotak commented Apr 29, 2022

/unhold

@jotak
Copy link
Member

jotak commented May 2, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4502513 into netobserv:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants