Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-321 query stats panels crashes netflow-traffic page #135

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 27, 2022

Fix query summary port sort crashing when formatPort was done before comparePorts

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@memodi
Copy link
Contributor

memodi commented Apr 27, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 27, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:de04c2c"]. It will expire after two weeks.

@memodi
Copy link
Contributor

memodi commented Apr 27, 2022

/lgtm
/qe-approved
tested with the pre-merge image and 0.1.2-rc1 operator bundle

@jotak
Copy link
Member

jotak commented Apr 28, 2022

/lgtm

@jpinsonneau jpinsonneau merged commit 0c6e3b5 into netobserv:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants