NETOBSERV-226 matrix merger implementation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 11, 2022
mariomac
reviewed
Apr 11, 2022
| pmodel "github.com/prometheus/common/model" | ||
| ) | ||
|
|
||
| type MatrixMerger struct { |
jpinsonneau
commented
Apr 11, 2022
| for r := range resChan { | ||
| //TODO: resp.Data.Stats are incorrect doing that |
There was a problem hiding this comment.
mariomac
approved these changes
Apr 11, 2022
jpinsonneau
force-pushed
the
matrix_merger
branch
from
a407b30 to
4f9a148
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #105 Matrix merger was not implemented
This adds the missing backend part to run topology queries keeping the
fetchParallelapproach.I have some concerns about performances since we are replacing Loki
Query Frontendrole by splitting queries on our side. This can generate thousands internal queries.https://grafana.com/docs/loki/latest/configuration/query-frontend/#parallelization
We can unlock the situation with this PR and decide what to do next after performance testing.