Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-235 Topology quick filtering #114

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 8, 2022

This PR adds quick actions on topology nodes:

  • filtering on a pod / service / unknown IP
  • info popover showing available info:
    • kind
    • namespace
    • name
    • address
    • host
  • pin (to keep node position on dynamic views and disable drag capability)

image

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mariomac
Copy link

mariomac commented Apr 8, 2022

It seems that the pods are automatically unpinned after a while (see video):

pinning.mp4

As an extra detail, at least in my screen is very difficult to distinguish between the dark green and the black color, so it's difficult to know when a pod is pinned or unpinned. Is there any different Icon to indicate that the pin is stuck?

@jpinsonneau
Copy link
Contributor Author

It seems that the pods are automatically unpinned after a while (see video):

Interesting, I'll check that. The pinned state is supposed to be reset only when changing display mode.
Thanks @mariomac !

@andrew-ronaldson what color / icon could you suggest ? I already used the TimesIcon on activated filter.

@andrew-ronaldson
Copy link

I think the colour should be primary blue --pf-color-bue--400 I think is the variable. When you click on a node is there a selected state applied to the node decorators or just on the node itself?

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Apr 8, 2022

I think the colour should be primary blue --pf-color-bue--400

I'll try that one 👍

When you click on a node is there a selected state applied to the node decorators or just on the node itself?

Only the node and its label with the blue color (default behavior)

@jpinsonneau
Copy link
Contributor Author

  • Fixed pin state lost after refresh
    • It will be still lost if you change display / group to avoid issues
  • Updated color (took from label when node is selected)
    image

@andrew-ronaldson
Copy link

  • Updated color (took from label when node is selected)
    image

Should the stroke match the background colour?

@jpinsonneau
Copy link
Contributor Author

Should the stroke match the background colour?

Sure, you have good eyesight !

image

@jpinsonneau jpinsonneau force-pushed the topology_filtering branch 2 times, most recently from f393024 to 87a45d4 Compare April 11, 2022 08:27
@mariomac mariomac self-assigned this Apr 11, 2022
@openshift-ci openshift-ci bot added the lgtm label Apr 13, 2022
@jpinsonneau jpinsonneau merged commit 3018198 into netobserv:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants