-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-244 Topology Export #113
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
web/save-svg-as-png.d.ts
Outdated
@@ -0,0 +1,14 @@ | |||
/** Declaration file generated by dts-gen */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is possible to put this file in a subfolder instead of the root web folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see we need an index.d.ts
file in root web
folder that imports others definitions files from anywhere and then export them.
For now we only have this one.
Would it be ok for you if I add this index.d.ts
file in root and put save-svg-as-png.d.ts
in a new types
folder ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's Ok. Not a big problem from my side if you think it's better to keep the save-sgv-as-png
file in the web
folder, if you think its a common/good practice for this kind of projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the end there is already a typedefs
folder for protocol-numbers
@mariomac so I moved save-sgv-as-png
to that folder
97d9277
to
9e46de8
Compare
This PR adds to topology an export button with simple
svg to png
conversion. This is a first step as a quick win until we develop other export formats.Action button:
Downloaded file: