Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-244 Topology Export #113

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 8, 2022

This PR adds to topology an export button with simple svg to png conversion. This is a first step as a quick win until we develop other export formats.

Action button:
image

Downloaded file:
topology (10)

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau marked this pull request as ready for review April 8, 2022 07:29
@@ -0,0 +1,14 @@
/** Declaration file generated by dts-gen */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is possible to put this file in a subfolder instead of the root web folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see we need an index.d.ts file in root web folder that imports others definitions files from anywhere and then export them.
For now we only have this one.

Would it be ok for you if I add this index.d.ts file in root and put save-svg-as-png.d.ts in a new types folder ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's Ok. Not a big problem from my side if you think it's better to keep the save-sgv-as-png file in the web folder, if you think its a common/good practice for this kind of projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the end there is already a typedefs folder for protocol-numbers @mariomac so I moved save-sgv-as-png to that folder

@mariomac
Copy link

LGTM. A minor (I think) issue that I think it could be addressed into another PR: the fonts of the exported SVG (serif) are different from the UI fonts (sans-serif).

image

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2022
@jpinsonneau jpinsonneau merged commit 2005aaa into netobserv:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants