avoid loop

netobserv · Dec 5, 2024 · a1cbc9b · a1cbc9b
1 parent 9a523da
commit a1cbc9b
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/web/src/components/netflow-traffic.tsx b/web/src/components/netflow-traffic.tsx
@@ -455,9 +455,11 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({
           })
           .catch(err => {
             const errStr = getHTTPErrorDetails(err, true);
+            const promErrStr = getPromError(errStr);
 
-            // check if it's a prom missing label error
-            if (isPromMissingLabelError(errStr)) {
+            // check if it's a prom missing label error and remove filters
+            // when the prom error is different to the new one
+            if (isPromMissingLabelError(errStr) && promErrStr !== model.chipsPopoverMessage) {
               let filtersDisabled = false;
               model.filters.list.forEach(filter => {
                 const fieldName = model.config.columns.find(col => col.filter === filter.def.id)?.field;
@@ -471,16 +473,18 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({
               if (filtersDisabled) {
                 // update filters to retrigger query without showing the error
                 updateTableFilters({ ...model.filters });
-                model.setChipsPopoverMessage(getPromError(errStr));
+                model.setChipsPopoverMessage(promErrStr);
                 return;
               }
             }
 
             // clear flows and metrics + show error
+            // always clear chip message to focus on the error
             model.setFlows([]);
             model.setMetrics(defaultNetflowMetrics);
             model.setError(errStr);
             model.setWarning(undefined);
+            model.setChipsPopoverMessage(undefined);
           })
           .finally(() => {
             const endDate = new Date();