NETOBSERV-1908 Be able to customize namespace #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 24.24% 24.24%
=======================================
Files 9 9
Lines 1415 1415
=======================================
Hits 343 343
Misses 1051 1051
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
jotak
reviewed
Dec 11, 2024
| @@ -33,7 +40,11 @@ RUN mkdir -p output | |||
| # Create final image from ubi + built binary and command | |||
| FROM --platform=linux/$TARGETARCH registry.access.redhat.com/ubi9/ubi:9.4 | |||
| WORKDIR / | |||
|
|
|||
| COPY --from=builder /opt/app-root/build . | |||
jotak
reviewed
Dec 11, 2024
cmd/flow_capture.go
Outdated
| log.Infof("Capture reached %s, exiting now...", maxTime) | ||
| return | ||
| if exit := onLimitReached(); exit { | ||
| log.Infof("Capture reached %s, exiting now...", sizestr.ToString(maxBytes)) |
There was a problem hiding this comment.
This been addressed in previous PRs 👍
jpinsonneau
force-pushed
the
1908
branch
2 times, most recently
from
d9ca630 to
88e981b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow custom namespace using
NETOBSERV_NAMESPACEenv variable.Example:
Dependencies
Based on #102
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.