NETOBSERV-889: fix too many colons in address error

[msherif1234]

This PR fixed two issues

1- when hostIP is IPv6 address we endup with following error when gRPC try to connect

collector="2604:1380:4642:7e00::5b:2055" component=exporter/GRPCProto error="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial tcp: address 2604:1380:4642:7e00::5b:2055: too many colons in address\""

for IPv6 we need to use [2604:1380:4642:7e00::5b]:2055 format.

2- on single stack ipv6 cluster with IPType=="any" , ipv4 DNS address was incorrectly used which prevented ebpf agent to come up and the pod stay in crashloop with this error:-

time="2023-02-16T21:06:17Z" level=fatal msg="can't instantiate NetObserv eBPF Agent" error="acquiring Agent IP: can't establish an external connection dial udp 8.8.8.8:80: connect: network is unreachable"

Signed-off-by: msherif1234 [email protected]

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-889 which is a valid jira issue.

In response to this:

Signed-off-by: msherif1234 [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-889 which is a valid jira issue.

In response to this:

when hostIP is IPv6 address we endup with following error when gRPC try to connect

collector="2604:1380:4642:7e00::5b:2055" component=exporter/GRPCProto error="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial tcp: address 2604:1380:4642:7e00::5b:2055: too many colons in address\""

for IPv6 we need to use [2604:1380:4642:7e00::5b]:2055 format.
Signed-off-by: msherif1234 [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #98 (726dc4a) into main (6a074bd) will increase coverage by 0.39%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   41.61%   42.00%   +0.39%     
==========================================
  Files          29       30       +1     
  Lines        1992     2002      +10     
==========================================
+ Hits          829      841      +12     
+ Misses       1125     1123       -2     
  Partials       38       38              

Flag	Coverage Δ
unittests	42.00% <60.00%> (+0.39%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/agent.go	39.78% <0.00%> (+0.71%)	⬆️
pkg/exporter/ipfix.go	0.00% <0.00%> (ø)
pkg/agent/ip.go	71.00% <100.00%> (+0.59%)	⬆️
pkg/exporter/grpc_proto.go	73.91% <100.00%> (+2.48%)	⬆️
pkg/grpc/client.go	68.75% <100.00%> (+2.08%)	⬆️
pkg/utils/utils.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:20a990e"]. It will expire after two weeks.

[Amoghrd]

@msherif1234 Tried updating the CSV with this eBPF image, the eBPF pods went to CrashLoopBackoff with error
time="2023-02-13T21:23:28Z" level=info msg="starting NetObserv eBPF Agent" time="2023-02-13T21:23:28Z" level=info msg="initializing Flows agent" component=agent.Flows time="2023-02-13T21:23:28Z" level=fatal msg="can't instantiate NetObserv eBPF Agent" error="acquiring Agent IP: can't establish an external connection dial udp 8.8.8.8:80: connect: network is unreachable"

[Amoghrd]

I get the same above error with source install too; after updating the eBPF image in deployments

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:0816e2c"]. It will expire after two weeks.

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:f073254"]. It will expire after two weeks.

[jotak]

/lgtm

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:ceaa4ca"]. It will expire after two weeks.

[memodi]

@msherif1234 Tried updating the CSV with this eBPF image, the eBPF pods went to CrashLoopBackoff with error time="2023-02-13T21:23:28Z" level=info msg="starting NetObserv eBPF Agent" time="2023-02-13T21:23:28Z" level=info msg="initializing Flows agent" component=agent.Flows time="2023-02-13T21:23:28Z" level=fatal msg="can't instantiate NetObserv eBPF Agent" error="acquiring Agent IP: can't establish an external connection dial udp 8.8.8.8:80: connect: network is unreachable"

tried this more and discussed error with @msherif1234 , our initial understanding of not being able to pull image: quay.io/netobserv/netobserv-ebpf-agent:ceaa4ca from quay was incorrect, it was able to pull Image and landing in above runtime error. This is likely a bug with new code.

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:a8e0892"]. It will expire after two weeks.

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:3652daa"]. It will expire after two weeks.

[memodi]

/qe-approved
Verified fix works for both IPv6 single stack and IPv4 clusters as well, thanks!

[memodi]

@jotak - is something wrong with labels? I don't see qe-approved label being added.

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-889 which is a valid jira issue.

In response to this:

This PR fixed two issues

1- when hostIP is IPv6 address we endup with following error when gRPC try to connect

collector="2604:1380:4642:7e00::5b:2055" component=exporter/GRPCProto error="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial tcp: address 2604:1380:4642:7e00::5b:2055: too many colons in address\""

for IPv6 we need to use [2604:1380:4642:7e00::5b]:2055 format.

2- on single stack ipv6 cluster with IPType=="any" , ipv4 DNS address was incorrectly used which prevented ebpf agent to come up and the pod stay in crashloop with this error:-

time="2023-02-16T21:06:17Z" level=fatal msg="can't instantiate NetObserv eBPF Agent" error="acquiring Agent IP: can't establish an external connection dial udp 8.8.8.8:80: connect: network is unreachable"

Signed-off-by: msherif1234 [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[OlivierCazade]

LGTM

[jotak]

thanks @msherif1234 !
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment