update github actions to use go1.21 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherif1234
force-pushed
the
update-gh
branch
from
87eeaf5 to
19ad3b9
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 31.71% 31.71%
=======================================
Files 37 37
Lines 3371 3371
=======================================
Hits 1069 1069
Misses 2239 2239
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jotak
reviewed
Oct 17, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/netobserv/netobserv-ebpf-agent | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
here it should be the minimum allowed, hence 1.20
msherif1234
force-pushed
the
update-gh
branch
from
19ad3b9 to
cfcab52
Compare
msherif1234
force-pushed
the
update-gh
branch
2 times, most recently
from
5c704d0 to
49e30a1
Compare
Signed-off-by: Mohamed Mahmoud <[email protected]>
Signed-off-by: Mohamed Mahmoud <[email protected]>
msherif1234
force-pushed
the
update-gh
branch
from
49e30a1 to
fa84b01
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update Github actions to use go1.21
make sure to set GOTOOLCHAIN to
localto avoid updatinggo.modby setting this envvar
go env -w GOTOOLCHAIN="local"Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.