-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1151: move flp decode grpc pipe to netobserv agent #466
NETOBSERV-1151: move flp decode grpc pipe to netobserv agent #466
Conversation
@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 65.96% 67.70% +1.73%
==========================================
Files 94 93 -1
Lines 6967 6648 -319
==========================================
- Hits 4596 4501 -95
+ Misses 2105 1883 -222
+ Partials 266 264 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
0d86573
to
fe22d94
Compare
@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fe22d94
to
03125e6
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=4391d7d make set-flp-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
03125e6
to
6469f5e
Compare
Signed-off-by: msherif1234 <[email protected]>
6469f5e
to
678a6a6
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes
depends on netobserv/netobserv-ebpf-agent#168