Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1151: move flp decode grpc pipe to netobserv agent #466

Merged

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 31, 2023

move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes

depends on netobserv/netobserv-ebpf-agent#168

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2023

@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.73% 🎉

Comparison is base (dc3e58e) 65.96% compared to head (678a6a6) 67.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   65.96%   67.70%   +1.73%     
==========================================
  Files          94       93       -1     
  Lines        6967     6648     -319     
==========================================
- Hits         4596     4501      -95     
+ Misses       2105     1883     -222     
+ Partials      266      264       -2     
Flag Coverage Δ
unittests 67.70% <0.00%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pipeline/decode/decode.go 57.14% <0.00%> (ø)
pkg/pipeline/ingest/ingest_grpc.go 73.97% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 1, 2023

@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue.

In response to this:

move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes

depends on netobserv/netobserv-ebpf-agent#168

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 23, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:4391d7d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4391d7d make set-flp-image

jpinsonneau
jpinsonneau previously approved these changes Sep 22, 2023
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2023
@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 22, 2023
@msherif1234 msherif1234 changed the title WIP: NETOBSERV-1151: move flp decode grpc pipe to netobserv agent NETOBSERV-1151: move flp decode grpc pipe to netobserv agent Sep 22, 2023
@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2023
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b18de28 into netobserv:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants