-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow, setup workflow-test #438
Conversation
jotak
commented
May 24, 2023
- Can trigger workflow from branch workflow-test
- Make default multi-arch to single amd64
- Remove specific ci targets; make shortlive builds more straightforward
- Disambiguate makefile env vs workflow env
- Remove unused targets
- Remove now unused shortlived dockerfile
- Can trigger workflow from branch workflow-test - Make default multi-arch to single amd64 - Remove specific ci targets; make shortlive builds more straightforward - Disambiguate makefile env vs workflow env - Remove unused targets - Remove now unused shortlived dockerfile
Hold on, something wrong here: the per-PR sha isn't in quay |
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 64.71% 64.74% +0.03%
==========================================
Files 94 94
Lines 6657 6657
==========================================
+ Hits 4308 4310 +2
+ Misses 2105 2104 -1
+ Partials 244 243 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
OK, my last commit fixed it Seems all good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jotak
I've pushed a new commit, to restore the |
/LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |