-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-984 - KafkaInterBrokerProtocalVersion throws warning and has ingestion errors #428
Conversation
New image: quay.io/netobserv/flowlogs-pipeline:bf793ba. It will expire after two weeks. |
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 64.72% 64.70% -0.03%
==========================================
Files 94 94
Lines 6645 6649 +4
==========================================
+ Hits 4301 4302 +1
- Misses 2100 2103 +3
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jpinsonneau @OlivierCazade i can test this on a fresh cluster tmrw, let me know if you seen any issues with the fix on the Baremetal cluster |
/label qe-approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rely on
TimeFlowEndMs
for kafka delay as theDecode
function returns a GenericMap that doesn't containsTimeFlowEnd
.Related PRs:
https://github.com/netobserv/flowlogs-pipeline/pull/203/files
https://github.com/netobserv/network-observability-console-plugin/pull/153/files