-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-962 - ADD write ipfix stage to pipeline builder #414
Conversation
@jpinsonneau if I'm not mistaken this PR still needs a NewIpfixPipeline and then the test based on that. I'm not sure how I should proceed for ipfix specifically. If you have any input let me know but I'll check on that as well. |
As far as I see the |
Changes: - Add WriteIpfix to pipeline_builder.go - Add NewWriteIpfixParams to stage_params Signed-off-by: acmenezes <[email protected]>
11f7c8f
to
e60a292
Compare
@jpinsonneau I guess I got it. Let me know if it's enough. I can adjust if needed. I'll pass to test in cluster if it goes well I'll convert the PR from draft to normal. |
Looks good ! Thanks @acmenezes 🥇 |
/approve to unlock netobserv/network-observability-operator#311 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 64.39% 64.41% +0.02%
==========================================
Files 94 94
Lines 6560 6564 +4
==========================================
+ Hits 4224 4228 +4
Misses 2096 2096
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@jotak @jpinsonneau , as we spoke:
This PR adds the write ipfix stage under the FLP pipeline builder in order to be used by the operator. The methods are reachable by the operator code this way. I tested by replacing the source while I made the changes.
Changes: