Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingest compilation #236

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

OlivierCazade
Copy link
Contributor

We merged two PR modifying the same file, and while they did not have direct conflict, it created some compilation type error.

@codecov-commenter
Copy link

Codecov Report

Merging #236 (f8a125a) into main (f711714) will increase coverage by 0.08%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   61.10%   61.19%   +0.08%     
==========================================
  Files          67       67              
  Lines        3849     3860      +11     
==========================================
+ Hits         2352     2362      +10     
- Misses       1346     1348       +2     
+ Partials      151      150       -1     
Flag Coverage Δ
unittests 61.19% <28.57%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/ingest/ingest_collector.go 48.09% <9.09%> (-3.13%) ⬇️
pkg/pipeline/encode/encode_kafka.go 69.35% <100.00%> (+1.55%) ⬆️
pkg/pipeline/utils/exit.go 100.00% <0.00%> (+41.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf65a90...f8a125a. Read the comment docs.

@OlivierCazade OlivierCazade merged commit 24bcbf2 into netobserv:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants