Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty flag to stage config #229

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

OlivierCazade
Copy link
Contributor

We recently started using the config API in the NOO to configure FLP.

Some attributes do not have the omitempty flag resulting in them getting converted in json with an empty string or 0 as value instead of using the internal default value of FLP.

@OlivierCazade OlivierCazade force-pushed the api-omitempty branch 3 times, most recently from a679fda to 0240ac1 Compare June 10, 2022 14:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #229 (18be06a) into main (217223d) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   61.53%   61.71%   +0.17%     
==========================================
  Files          67       67              
  Lines        3897     3897              
==========================================
+ Hits         2398     2405       +7     
+ Misses       1352     1346       -6     
+ Partials      147      146       -1     
Flag Coverage Δ
unittests 61.71% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/conn_track.go 100.00% <ø> (ø)
pkg/api/encode_kafka.go 100.00% <ø> (ø)
pkg/api/encode_prom.go 100.00% <ø> (ø)
pkg/api/transform_filter.go 100.00% <ø> (ø)
pkg/api/transform_generic.go 0.00% <ø> (ø)
pkg/api/transform_network.go 100.00% <ø> (ø)
pkg/pipeline/utils/exit.go 100.00% <0.00%> (+41.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217223d...18be06a. Read the comment docs.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OlivierCazade OlivierCazade merged commit 4549b72 into netobserv:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants