Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common cache with expiry time #204

Merged
merged 8 commits into from
Jun 9, 2022
Merged

Conversation

KalmanMeth
Copy link
Collaborator

Refactor multiple instances of LRU cache into shared code.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #204 (9d7f153) into main (3f5317c) will increase coverage by 0.13%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   57.95%   58.09%   +0.13%     
==========================================
  Files          58       60       +2     
  Lines        3361     3374      +13     
==========================================
+ Hits         1948     1960      +12     
- Misses       1282     1283       +1     
  Partials      131      131              
Flag Coverage Δ
unittests 58.09% <93.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/encode/encode_prom.go 75.56% <68.42%> (-6.21%) ⬇️
...ansform/connection_tracking/connection_tracking.go 94.28% <80.00%> (-3.22%) ⬇️
pkg/pipeline/extract/aggregate/aggregate.go 95.71% <100.00%> (+1.75%) ⬆️
pkg/pipeline/extract/aggregate/aggregates.go 90.38% <100.00%> (-0.19%) ⬇️
pkg/pipeline/utils/timed_cache.go 100.00% <100.00%> (ø)
pkg/pipeline/conntrack/hash.go 81.25% <0.00%> (ø)
pkg/pipeline/utils/exit.go 100.00% <0.00%> (+41.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5317c...9d7f153. Read the comment docs.

@KalmanMeth KalmanMeth changed the title Common lru Common cache with expiry time May 17, 2022
@KalmanMeth KalmanMeth requested review from ronensc and eranra and removed request for ronensc May 24, 2022 08:57
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/extract/aggregate/aggregate.go Outdated Show resolved Hide resolved
pkg/pipeline/encode/encode_prom_test.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/extract/aggregate/aggregate.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
pkg/pipeline/utils/timed_cache.go Outdated Show resolved Hide resolved
@KalmanMeth KalmanMeth merged commit debee4d into netobserv:main Jun 9, 2022
@KalmanMeth KalmanMeth deleted the common-LRU branch January 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add common LRU cache for: conn_track, encode_prom, and extract_aggregate
3 participants