Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom network service names #174

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

eranra
Copy link
Collaborator

@eranra eranra commented Apr 6, 2022

No description provided.

@eranra
Copy link
Collaborator Author

eranra commented Apr 6, 2022

@jpinsonneau I know that this is not used in the UI (the resolution is done in the UI) ... but still this adds the ability to custom the network services names using FLP - if we decide to use that <<--- maybe adding this feature also to the frontend makes sense.

@eranra eranra force-pushed the 96_custom_network_service_names branch from ed2e9b4 to c712a3b Compare April 6, 2022 13:45
@jpinsonneau
Copy link
Collaborator

@jpinsonneau I know that this is not used in the UI (the resolution is done in the UI) ... but still this adds the ability to custom the network services names using FLP - if we decide to use that <<--- maybe adding this feature also to the frontend makes sense.

Cool @eranra thanks for the update. @OlivierCazade is the one who implemented the config on front end side btw.

I feel frontend config is enough for now but I agree we can add an option to be able to switch or even manage both with a merge mecanism 👍

@eranra eranra force-pushed the 96_custom_network_service_names branch from c712a3b to 8359f35 Compare April 7, 2022 07:52
@eranra eranra requested a review from KalmanMeth April 7, 2022 07:59
@eranra eranra added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 10, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/flowlogs-pipeline:9699457"]. It will expire after two weeks.

@eranra eranra force-pushed the 96_custom_network_service_names branch from 8359f35 to 99198c9 Compare April 10, 2022 11:28
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 10, 2022
@eranra eranra merged commit 9e8e6f5 into netobserv:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network transform: custom service names in "AddService" operation
3 participants