test: refactor tests #1040
test: refactor tests #1040
Conversation
erezrokah
added
the
type: chore
| const test = require('ava') | ||
| const stripAnsi = require('strip-ansi') | ||
| const cliPath = require('./utils/cliPath') | ||
| const exec = require('./utils/exec') |
There was a problem hiding this comment.
./utils/exec is a promisified version of node exec.
We were actually spawning commands in 3 different ways in the tests.
- Using
./utils/exec(addons tests) - Using a promisified
execduplicating./utils/execlogic (dev command tests) - Using
execa(build command tests).
I aligned the places I could find to use execa and removed ./utils/exec
There was a problem hiding this comment.
YES! 🎉
Child process spawning is complex :P
| @@ -0,0 +1,793 @@ | |||
| const test = require('ava') | |||
There was a problem hiding this comment.
This file was refactored and renamed from dev.test.js.
Each test creates a dedicated site with the relevant settings just for that test
tests/command.dev.test.js
Outdated
| const response1 = await fetch(`${server.url}/not-foo`).then(r => r.text()) | ||
| const response2 = await fetch(`${server.url}/not-foo/`).then(r => r.text()) | ||
|
|
||
| // TODO: check why this doesn't redirect |
There was a problem hiding this comment.
Kept this from the original test, still not sure what I'm missing here
| @@ -0,0 +1,29 @@ | |||
| const test = require('ava') | |||
There was a problem hiding this comment.
This test was inside dev.test.js.
Since it tests a different command I moved it to a separate file.
| const tempy = require('tempy') | ||
| const os = require('os') | ||
|
|
||
| const createSiteBuilder = ({ siteName }) => { |
There was a problem hiding this comment.
At some point I would like to add withUISetting which will use the API to create and update the site.
erezrokah
force-pushed
the
test/refactor_tests
branch
from
8faed26 to
2da6794
Compare
| host, | ||
| port, | ||
| close: async () => { | ||
| const pids = await pidtree(ps.pid).catch(() => []) |
There was a problem hiding this comment.
|
@ehmicky, sorry for the site of this PR, got too deep and had to dig my way out of it by doing more refactoring 😄 |
erezrokah
force-pushed
the
test/refactor_tests
branch
2 times, most recently
from
fa9feae to
89c6325
Compare
erezrokah
force-pushed
the
test/refactor_tests
branch
from
89c6325 to
b85a7d4
Compare
erezrokah
force-pushed
the
test/refactor_tests
branch
from
b85a7d4 to
0f0d6bd
Compare
Fixes #1031
Also renamed many tests so their description matches what we're testing.
Also renamed
dev.test.jstocommand.dev.test.js(soon to be followed in another PR forbuild.test.js)