fix: fix compatibility with latest versions of ts-node

TSError now sets diagnosticText to be non-enumerable so we need to grab it manually In 10.5.0 ts-node added a new config option tsTrace which is a function. Functions are not serializable so we need to filter functions out.
netlify · Jun 9, 2022 · 1663b1d · 1663b1d
1 parent 5eaee3c
commit 1663b1d
Show file tree

Hide file tree

Showing 6 changed files with 55 additions and 135 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/build/package.json b/packages/build/package.json
@@ -103,7 +103,7 @@
     "strip-ansi": "^7.0.0",
     "supports-color": "^9.0.0",
     "tmp-promise": "^3.0.2",
-    "ts-node": "10.4.0",
+    "ts-node": "^10.6.0",
     "typescript": "^4.5.4",
     "update-notifier": "^5.0.0",
     "uuid": "^8.0.0",

diff --git a/packages/build/src/error/build.js b/packages/build/src/error/build.js
@@ -34,7 +34,15 @@ const assignErrorProp = function (error, name, value) {
 }
 
 // Inverse of `jsonToError()`.
-export const errorToJson = function ({ name, message, stack, [CUSTOM_ERROR_KEY]: customError, ...errorProps }) {
+export const errorToJson = function (error) {
+  const { name, message, stack, [CUSTOM_ERROR_KEY]: customError, ...errorProps } = error
+
+  // diagnosticText is not enumerable in TSError so we need to grab it manually. destructuring won't work.
+  if (error.diagnosticText) {
+    // eslint-disable-next-line fp/no-mutation
+    errorProps.diagnosticText = error.diagnosticText
+  }
+
   return {
     ...safeJsonStringify.ensureProperties(errorProps),
     ...safeJsonStringify.ensureProperties({ name, message, stack, [CUSTOM_ERROR_KEY]: customError }),

diff --git a/packages/build/src/plugins/child/typescript.js b/packages/build/src/plugins/child/typescript.js
@@ -27,8 +27,14 @@ export const addTsErrorInfo = function (error, tsNodeService) {
     config: {
       raw: { compilerOptions },
     },
-    options: tsNodeOptions,
+    options: realTsNodeOptions,
   } = tsNodeService
+
+  // filter out functions as they cannot be serialized
+  const tsNodeOptions = Object.fromEntries(
+    Object.entries(realTsNodeOptions).filter(([, val]) => typeof val !== 'function'),
+  )
+
   addErrorInfo(error, { tsConfig: { compilerOptions, tsNodeOptions } })
 }
 

diff --git a/packages/build/tests/plugins/snapshots/tests.js.md b/packages/build/tests/plugins/snapshots/tests.js.md
@@ -2519,8 +2519,8 @@ Generated by [AVA](https://avajs.dev).
     ␊
       Error properties␊
       {␊
-        diagnosticText: 'plugin.ts(8,3): error TS2554: Expected 1-2 arguments, but got 0./n',␊
-        diagnosticCodes: [ 2554 ]␊
+        diagnosticCodes: [ 2554 ],␊
+        diagnosticText: 'plugin.ts(8,3): error TS2554: Expected 1-2 arguments, but got 0./n'␊
       }␊
     ␊
       Resolved config␊

diff --git a/packages/build/tests/plugins/snapshots/tests.js.snap b/packages/build/tests/plugins/snapshots/tests.js.snap