-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support (config, workflow to detect/not fix) and make it fix few typos #27
Conversation
…(but ignoring overall fail due to ambigous ones) === Do not change lines below === { "chain": [], "cmd": "codespell -w || :", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
=== Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 78.84% 76.17% -2.68%
==========================================
Files 2 2
Lines 1026 1024 -2
==========================================
- Hits 809 780 -29
- Misses 217 244 +27 ☔ View full report in Codecov by Sentry. |
Spotted while running tests... apparently there is a known issue and words near single quotes are not detected since that quote could be a part of the word: codespell-project/codespell#3305
Really like this one ^^ |
Just used this on another repo, works like a charm. |
action is just a wrapper around the FWIW -- if you eventually add |
FWIW if you are using black, can also start using pre-commit and then add codespell there too... See e.g. our https://github.com/dandi/dandi-cli/blob/master/.pre-commit-config.yaml For adding to other projects, consider (generalizing or adopting) my crude helper: https://github.com/yarikoptic/improveit/blob/main/codespellit |
Thank you for the insight. Adopted codespell. |
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.