Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phone-island call. handle NethLink case #262

Merged
merged 9 commits into from
Nov 15, 2024
Merged

phone-island call. handle NethLink case #262

merged 9 commits into from
Nov 15, 2024

Conversation

tonyco97
Copy link
Collaborator

@tonyco97 tonyco97 commented Nov 4, 2024 •
edited
Loading

  • Deleted empty space on mailto function
  • If user has desktop as main device, use callto protocol to invoke Nethlink phone-island instead of NethvoiceCTI web app phone-island
  • Fixed wrong indexes for button configuration for physical phones
  • Added missing translations
  • Added copy to clipboard on email
  • Enhanced react tooltip call method in various components.
  • Updated tooltips to use data-tooltip-id and data-tooltip-content attributes.
  • Replaced CallsSource and CallsDestination with CallDetails in UserLastCallsContent.tsx.
  • Fixed wrong default_device if user has physical device setted as main device
  • Use CallTo protocol if user has Nethlink as main device

Reference: NethServer/dev#7087
Reference: NethServer/dev#7060

@tonyco97 tonyco97 self-assigned this Nov 4, 2024
@tonyco97 tonyco97 marked this pull request as draft November 4, 2024 09:32
@edospadoni edospadoni marked this pull request as ready for review November 4, 2024 14:24
@edospadoni edospadoni changed the title Create callTo protocol phone-island call. handle NethLink case Nov 4, 2024
@tonyco97 tonyco97 marked this pull request as draft November 8, 2024 09:13
@tonyco97 tonyco97 marked this pull request as ready for review November 15, 2024 09:14
@tonyco97 tonyco97 requested a review from edospadoni November 15, 2024 09:14
@tonyco97 tonyco97 merged commit 90ef8fa into main Nov 15, 2024
1 check passed
@tonyco97 tonyco97 deleted the callToProtocol branch November 15, 2024 10:47
@edospadoni edospadoni mentioned this pull request Nov 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edospadoni edospadoni Awaiting requested review from edospadoni

Assignees

@tonyco97 tonyco97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyco97 @edospadoni