Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Shared Slice Properties #545

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Support Shared Slice Properties #545

merged 2 commits into from
Oct 31, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 31, 2024

Adds the id, variation and version properties present in shared slices along with methods to retrieve the values

@gsteel gsteel added the enhancement New feature or request label Oct 31, 2024
@gsteel gsteel added this to the 1.11.0 milestone Oct 31, 2024
@gsteel gsteel self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (9f04559) to head (9147136).
Report is 3 commits behind head on 1.11.x.

Additional details and impacted files
@@             Coverage Diff              @@
##             1.11.x     #545      +/-   ##
============================================
+ Coverage     97.87%   97.91%   +0.03%     
- Complexity      666      676      +10     
============================================
  Files            51       51              
  Lines          1835     1867      +32     
============================================
+ Hits           1796     1828      +32     
  Misses           39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsteel gsteel merged commit bc52738 into 1.11.x Oct 31, 2024
17 checks passed
@gsteel gsteel deleted the shared-slices branch October 31, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant