Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery Dependency #11710

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Update jQuery Dependency #11710

merged 1 commit into from
Nov 2, 2021

Conversation

rupokify
Copy link
Contributor

@rupokify rupokify commented Oct 24, 2021

Summary

Fixes: #11742

"master" branch now has jQuery 3.6.0 (https://github.com/netdata/netdata/tree/master/web/gui/dashboard/lib) but the dependency still calls jQuery 2.2.4 (https://github.com/netdata/netdata/blob/master/web/gui/src/dashboard.js/dependencies.js Line: 7)

Component Name

Web GUI

@rupokify rupokify requested a review from jacekkolasa as a code owner October 24, 2021 09:01
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2021

CLA assistant check
All committers have signed the CLA.

@ilyam8
Copy link
Member

ilyam8 commented Nov 2, 2021

@rupokify hi, thanks for the fix! The CLA is not signed, the problem is

Rupok Chowdhury Protik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA.

@rupokify
Copy link
Contributor Author

rupokify commented Nov 2, 2021

@ilyam8 Fixed. Now CLA Assistant says:

All committers have signed the CLA.

@ilyam8 ilyam8 merged commit 9d08d44 into netdata:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 101: Cannot load jQuery: [...]/lib/jquery-2.2.4.min.js
4 participants