chore(wmi): rename apps to processes plus small fixes #954
Conversation
| sort.Slice(procs, func(i, j int) bool { return procs[i] < procs[j] }) | ||
|
|
||
| for _, id := range procs { | ||
| if w.cache.procs[id] { |
There was a problem hiding this comment.
Why did you abbreviate process ?
There was a problem hiding this comment.
Because I decided to do so - procs/processes. Does it look like a problem for you?
There was a problem hiding this comment.
No, it is not a problem.
When I brought abbreviation for apps, it was because this is the way we work on Linux/BSD/Mac. On the other hand we are not abbreviating memory when we could.
I am still trying to understand the pattern. 🤔
There was a problem hiding this comment.
w.cache.procs
That is a private variable. Why does it bother you how I name it?
There was a problem hiding this comment.
Or do you talk about something different? I am commenting on the highlighted code.
There was a problem hiding this comment.
I understand this is an internal variable, but why should it to be the unique with abbreviation when others do not have? 🤔
No description provided.