Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

add prometheus integrations to multi_metadata.yaml #1253

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

shyamvalsan
Copy link
Contributor

@shyamvalsan shyamvalsan commented Jul 20, 2023

Keywords still to be updated.

@ilyam8
Copy link
Member

ilyam8 commented Jul 20, 2023

  • please make sentences single lines if using |.
        metrics_description: |
          Monitor GPSD (GPS daemon) metrics for efficient GPS
          data management and performance.
        method_description: |
          Metrics are gathered by periodically sending HTTP requests
          to [gpsd exporter](https://github.com/natesales/gpsd-exporter) and parsing
              the response.

=>

        metrics_description: |
          Monitor GPSD (GPS daemon) metrics for efficient GPS data management and performance.
        method_description: |
          Metrics are gathered by periodically sending HTTP requests to [gpsd exporter](https://github.com/natesales/gpsd-exporter) and parsing the response.
  • can you please filter out things that are not on GitHub

As it is now we end up with

Metrics are gathered by periodically sending HTTP requests https://www.webweaver.de/
Install https://www.webweaver.de/ by following the instructions mentioned in the exporter README.

Please check https://www.webweaver.de/ and try to follow their instructions to install the "exporter".

I am very doubtful we need such "integrations".

@sashwathn
Copy link
Contributor

@shyamvalsan : Are we good to merge this now?
@Ancairon : Did we create a key to define "Community" integrations in the schema? We only need to add this "optional" field on this metadata.yaml.

@Ancairon
Copy link
Member

I made netdata/netdata#15465 and merged it, so we got that field

@ilyam8
Copy link
Member

ilyam8 commented Jul 20, 2023

No, we are not good to merge it.

If you want guys I can do these ^^ changes myself quickly and merge

@sashwathn
Copy link
Contributor

sashwathn commented Jul 20, 2023

No, we are not good to merge it.

If you want guys I can do these ^^ changes myself quickly and merge

@ilyam8 : Since we are now explicitly marking these as "Community" integrations, I think it is okay to have all of these. At least all of these are listed on the https://github.com/prometheus/prometheus/wiki/Default-port-allocations link.
I don't see this as a Blocker. We can remove these at a later point also based on user feedback etc.

Our search in the integrations section also says 1000+ integrations - so I am assuming @ktsaou wants as many as we can have?
image

@ilyam8
Copy link
Member

ilyam8 commented Jul 20, 2023

I have no problems with 1000+ but the number is not the only goal, they at least shouldn't be super low quality/senseless. I don't say drop the rest, we need just to verify things and add them after.

@shyamvalsan
Copy link
Contributor Author

I am trying to do a round of verifying before adding them in.

@ilyam8
Copy link
Member

ilyam8 commented Jul 20, 2023

@shyamvalsan, let's add exporters in the first round and merge. Then let's have another PR so the rest won't block exporters.

@shyamvalsan
Copy link
Contributor Author

shyamvalsan commented Jul 20, 2023

@ilyam8 I made another push. please take a look. (If there's still issues, feel free to jump in and update as I will be on customer calls for the next hour or so)

I have only taken out 2-3 entries where the link pointed to something with no useful info about the exporter. The others are linking to the exporter info even if it is not in github. So I am keeping them for now.

cc: @sashwathn @Ancairon

@ilyam8 ilyam8 merged commit f2dba98 into netdata:master Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants