Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #17310 - Properly restrict GraphQL related object queries #17312

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fixes: #17310 - Properly restrict GraphQL related object queries #17312

merged 3 commits into from
Aug 30, 2024

Conversation

DanSheps
Copy link
Member

Fixes: #17310

  • Properly restrict GraphQL related object queries
  • Update tests to handle additional permission requirements

@DanSheps DanSheps changed the base branch from develop to feature August 30, 2024 02:29
@DanSheps DanSheps self-assigned this Aug 30, 2024
@DanSheps DanSheps added beta Concerns a bug/feature in a beta release and removed beta Concerns a bug/feature in a beta release labels Aug 30, 2024
@DanSheps DanSheps added this to the v4.1 milestone Aug 30, 2024
@DanSheps DanSheps changed the base branch from feature to develop August 30, 2024 14:59
@DanSheps DanSheps changed the base branch from develop to feature August 30, 2024 15:00
@DanSheps DanSheps changed the base branch from feature to develop August 30, 2024 15:09
@DanSheps DanSheps force-pushed the 17310-fix-graphql-related-objects-restriction branch from 4575af1 to 950e291 Compare August 30, 2024 15:18
@DanSheps DanSheps requested a review from jeremystretch August 30, 2024 16:51
@DanSheps DanSheps modified the milestone: v4.1 Aug 30, 2024
jeremystretch
jeremystretch approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 4fead1c into develop Aug 30, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17310-fix-graphql-related-objects-restriction branch August 30, 2024 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

@DanSheps DanSheps

Labels
None yet
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

GraphQL related objects are not properly restricted
2 participants
@DanSheps @jeremystretch