Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default font "Plus Jakarta Sans" supports only Latin writing system. #17511

Closed
welqd opened this issue Sep 17, 2024 · 2 comments · Fixed by #17592
Closed

The default font "Plus Jakarta Sans" supports only Latin writing system. #17511

welqd opened this issue Sep 17, 2024 · 2 comments · Fixed by #17592
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@welqd
Copy link

welqd commented Sep 17, 2024

Deployment Type

Self-hosted

NetBox Version

v4.1.0

Python Version

3.11

Steps to Reproduce

Hello.
Firstly, thank you for all your work.

The problem is that the default font "Plus Jakarta Sans" is not very versatile, I believe it only supports the Latin writing system.
This results in an inconsistent look as shown below on the screen (Russian interface language).

image

Screen from Google fonts.
image

I believe it was introduced in the pull request #16848 through variable

 --tblr-font-sans-serif: "Plus Jakarta Sans Variable", system-ui, sans-serif;

Expected Behavior

Since the project aims to support multiple languages, choose a more universal font, if possible.

Observed Behavior


@welqd welqd added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Sep 17, 2024
@welqd welqd changed the title The default font "Plus Jakarta Sans Variable" supports only Latin writing system. The default font "Plus Jakarta Sans" supports only Latin writing system. Sep 17, 2024
@jeremystretch
Copy link
Member

jeremystretch commented Sep 17, 2024

I believe it only supports the Latin writing system.

Per Google Fonts this appears to be accurate. I think what you're seeing in the screenshots is one of the fallback system fonts.

IMO we should move back to the original Inter font.

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Sep 17, 2024
@goteamkor
Copy link

goteamkor commented Sep 17, 2024

IMO we should move back to the original Inter font.

agree. would likely address #17240
see #17091 (comment) for more context.

@jeremystretch jeremystretch self-assigned this Sep 24, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Sep 24, 2024
jeremystretch added a commit to alehaa/netbox that referenced this issue Oct 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants