Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ENABLE_LOCALIZATION configuration parameter #15752

Closed
jeremystretch opened this issue Apr 17, 2024 · 0 comments
Closed

Remove the ENABLE_LOCALIZATION configuration parameter #15752

jeremystretch opened this issue Apr 17, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove support for the ENABLE_LOCALIZATION configuration parameter. As a result of removing this parameter, the Django setting USE_I18N will default to True, and LocaleMiddleware will always be enabled.

Justification

As localization is now enforced in Django 5.0 and NetBox restricts the set of available translation languages to those for which string maps have been generated, this setting is no longer needed.

Impact

Translation and localization will always be enabled.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Apr 17, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Apr 17, 2024
@jeremystretch jeremystretch self-assigned this Apr 17, 2024
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15752: Remove the ENABLE_LOCALIZATION configuration parameter
f44c2ec
@jeremystretch jeremystretch mentioned this issue Apr 17, 2024
Merged
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15752: Remove the ENABLE_LOCALIZATION configuration parameter
6ccfbb0
jeremystretch added a commit that referenced this issue Apr 17, 2024
@jeremystretch
Closes #15752: Remove the ENABLE_LOCALIZATION configuration parameter
95cc29d
This was referenced May 6, 2024
Merged
Closed
@amyasnikov amyasnikov mentioned this issue May 9, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch